MichaelContento/redux-storage
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases 21 Packages Wiki Activity Actions

Splitting the decorators from the core #88

New issue
Closed
opened 2016-02-05 11:21:59 +00:00 by mathieudutour · 5 comments
mathieudutour commented 2016-02-05 11:21:59 +00:00 (Migrated from github.com)
Copy link

Right now, when using this package without immutable, it will still require immutablejs which is quite big.

Each decorators should be required separately or be in its own package.

Right now, when using this package without immutable, it will still require immutablejs which is quite big. Each decorators should be required separately or be in its own package.
michaelcontento commented 2016-02-05 11:31:56 +00:00 (Migrated from github.com)
Copy link

Good point! Which solution do you prefer?

  1. Own require for decorators (similar how we handle engines currently)
  2. Like 1) but only for the immutable decorator
  3. Move all decorators into own packages
  4. Move all decorators and all engines into own packages
Good point! Which solution do you prefer? 1) Own require for decorators (similar how we handle engines currently) 2) Like 1) but only for the immutable decorator 3) Move all decorators into own packages 4) Move all decorators **and** all engines into own packages
mathieudutour commented 2016-02-05 11:34:00 +00:00 (Migrated from github.com)
Copy link

Own require for decorators is the solution demanding the less work I think. I quite like it, it keeps the package.json clean

Own require for decorators is the solution demanding the less work I think. I quite like it, it keeps the package.json clean
michaelcontento commented 2016-02-05 11:41:19 +00:00 (Migrated from github.com)
Copy link

I'm currently unsure. Yes, own require would be very easy. But as we're about to introduce a breaking API change, I'm willing to go a few more steps 😃

IMHO solution 4) would be the cleanest. We would also get proper dependency support for redux-storage/engines/reactNativeAsyncStorage.

I'm currently unsure. Yes, own require would be very easy. But as we're about to introduce a breaking API change, I'm willing to go a few more steps :smiley: IMHO solution 4) would be the cleanest. We would also get proper dependency support for `redux-storage/engines/reactNativeAsyncStorage`.
mathieudutour commented 2016-02-05 11:41:55 +00:00 (Migrated from github.com)
Copy link

Good point

Good point
alizbazar commented 2016-02-08 12:32:03 +00:00 (Migrated from github.com)
Copy link

👍

👍
This discussion has been locked. Commenting is limited to contributors.
No Branch/Tag specified
Branches Tags
master
4.1.1
4.1.0
4.0.1
4.0.0
3.0.1
3.0.0
2.2.0
2.1.1
2.1.0
2.0.1
2.0.0
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.4
1.3.3
1.3.2
1.3.1
1.3.0
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.6
1.1.5
1.1.4
1.1.2
1.1.1
1.1.0
1.0.0
0.0.2
0.0.1
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
greenkeeper

   
help wanted

   
invalid

   
waiting for feedback

   
wontfix
No labels
bug
duplicate
enhancement
greenkeeper
help wanted
invalid
waiting for feedback
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
MichaelContento/redux-storage#88
No description provided.